Skip to content

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 27, 2019

I find it hard to find which one to use with chain when I only need to
chain one value. Also once talks about chain.

@rust-highfive
Copy link
Contributor

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2019
@Centril
Copy link
Contributor

Centril commented Oct 27, 2019

r? @Centril @bors rollup

r=me with comment addressed.

@Centril
Copy link
Contributor

Centril commented Oct 27, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 27, 2019

📌 Commit b626448 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 27, 2019
doc: introduce `once` in `iter::chain` document

I find it hard to find which one to use with `chain` when I only need to
chain one value. Also [`once`][1] talks about `chain`.

[1]: https://doc.rust-lang.org/nightly/std/iter/fn.once.html
@tesuji tesuji force-pushed the iter-chain-once branch 2 times, most recently from cceee42 to eda2d47 Compare October 28, 2019 03:17
@tesuji
Copy link
Contributor Author

tesuji commented Oct 28, 2019

The example compiles on godbolt: https://rust.godbolt.org/z/Edpz4b
Sorry for making the rollup failed.

@tesuji
Copy link
Contributor Author

tesuji commented Oct 28, 2019

Ping

@Centril
Copy link
Contributor

Centril commented Oct 28, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 28, 2019

📌 Commit 9c4f60e has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Oct 28, 2019
doc: introduce `once` in `iter::chain` document

I find it hard to find which one to use with `chain` when I only need to
chain one value. Also [`once`][1] talks about `chain`.

[1]: https://doc.rust-lang.org/nightly/std/iter/fn.once.html
bors added a commit that referenced this pull request Oct 28, 2019
Rollup of 9 pull requests

Successful merges:

 - #65563 (Add long error explanation for E0587)
 - #65640 (Use heuristics to recover parsing of missing `;`)
 - #65643 (Correct handling of type flags with `ConstValue::Placeholder`)
 - #65825 (rustc: use IndexVec<DefIndex, T> instead of Vec<T>.)
 - #65858 (suggest `const_in_array_repeat_expression` flag)
 - #65877 (doc: introduce `once` in `iter::chain` document)
 - #65887 (doc: mention `get(_mut)` in Vec)
 - #65891 (self-profiling: Record something more useful for crate metadata generation event.)
 - #65893 (Output previous stable  error messaging when using stable build.)

Failed merges:

r? @ghost
@bors bors merged commit 9c4f60e into rust-lang:master Oct 29, 2019
@tesuji tesuji deleted the iter-chain-once branch October 29, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants